Make strict dropCR behavior optional via ParseOptions#78
Open
EmmanuelAC1 wants to merge 4 commits intosourcegraph:masterfrom
Open
Make strict dropCR behavior optional via ParseOptions#78EmmanuelAC1 wants to merge 4 commits intosourcegraph:masterfrom
EmmanuelAC1 wants to merge 4 commits intosourcegraph:masterfrom
Conversation
Author
|
Hi @keegancsmith! I created this PR to make the dropCR behavior optional but keeping current behavior by default for backward compatibility. I'm not able to assign reviewers myself. Could you help guide me on how to get this reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the library strictly drops all trailing carriage returns (\r) from lines. This change introduces a mechanism to optionally preserve them while maintaining backward compatibility.
Detail:
ParseOptionsstruct with aKeepCRfield.*Optionsvariants for [ParseMultiFileDiff],ParseHunks, and their correspondingNew*Readerconstructors.lineReaderandreadLineto respect theKeepCRoption.KeepCR: false, ensuring no breaking changes for current users.KeepCRbehavior.